Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8228): get referrer as config option #31

Merged
merged 3 commits into from
May 22, 2018
Merged

fix(FEC-8228): get referrer as config option #31

merged 3 commits into from
May 22, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 21, 2018 •
edited
Loading

Description of the Changes

take the referrer from the config. depends on kaltura/kaltura-player-js#123

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this May 21, 2018
@yairans yairans requested review from OrenMe, dan-ziv and odedhutzler May 21, 2018 14:16
@yairans yairans mentioned this pull request May 21, 2018
Merged
5 tasks
@OrenMe OrenMe changed the title fix(FEC-8228): Incorrect referrer param on the playManifest request a… fix(FEC-8228): get referrer as config option May 22, 2018
yairans added a commit to kaltura/kaltura-player-js that referenced this pull request May 22, 2018
@yairans
fix(FEC-8228): calculate correct referrer param for inline and iframe…
71401cc 
… embeds (#123)

* acquire the referrer from the document.URL unless is an iframe then acquire it from document.referrer
* limit the referrer to 1K length
* pass the referrer to kanalytics plugin via config see kaltura/playkit-js-kanalytics#31
@yairans yairans merged commit 00b1e58 into master May 22, 2018
@yairans yairans deleted the FEC-8228 branch May 22, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe