Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-25160: Allow disabling flavors optimization in playManifestAction #13165

Merged
merged 1 commit into from
Mar 11, 2025
Merged

PLAT-25160: Allow disabling flavors optimization in playManifestAction #13165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions alpha/apps/kaltura/modules/extwidget/actions/playManifestAction.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,6 +1047,11 @@ protected function optimizeFlavors()
return;
}

if (PermissionPeer::isValidForPartner(PermissionName::FEATURE_DISABLE_FLAVORS_OPTIMIZATION, $this->entry->getPartnerId()))
{
return;
}

$flavors = $this->deliveryAttributes->getFlavorAssets();

usort($flavors, array($this, 'sortFlavorsByFrameSizeAndBitrate'));
Expand Down
1 change: 1 addition & 0 deletions alpha/lib/enums/PermissionName.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,4 +308,5 @@ interface PermissionName extends BaseEnum
const FEATURE_DISABLE_NO_CATEGORY_ENTRY_ENTITLEMENT_CHECK = "FEATURE_DISABLE_NO_CATEGORY_ENTRY_ENTITLEMENT_CHECK";

const FEATURE_DISABLE_NEW_ICAL_STANDARD = 'FEATURE_DISABLE_NEW_ICAL_STANDARD';
const FEATURE_DISABLE_FLAVORS_OPTIMIZATION = 'FEATURE_DISABLE_FLAVORS_OPTIMIZATION';
}
6 changes: 6 additions & 0 deletions configurations/admin.template.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,6 +1263,12 @@ moduls.disableNewIcalStandard.label = "Use kaltura iCal V1"
moduls.disableNewIcalStandard.permissionName = FEATURE_DISABLE_NEW_ICAL_STANDARD
moduls.disableNewIcalStandard.group = GROUP_ENABLE_DISABLE_FEATURES

moduls.embedShareStream.enabled = true
moduls.embedShareStream.permissionType = 2
moduls.embedShareStream.label = "Disable flavors optimization"
moduls.embedShareStream.permissionName = FEATURE_DISABLE_FLAVORS_OPTIMIZATION
moduls.embedShareStream.group = GROUP_ENABLE_DISABLE_FEATURES

; ACCESS PERMISSIONS

access.error = *
Expand Down
Loading