Skip to content

Commit

Permalink
ci: lint and commitlint in its own workflow
Browse files Browse the repository at this point in the history
Fixes #311
  • Loading branch information
Jonathan Ginsburg committed Apr 4, 2022
1 parent f78bbec commit 394ba52
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 6 deletions.
33 changes: 33 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Lint

on:
pull_request:
branches:
- master

jobs:
linux:
name: "Node ${{ matrix.node }} on Linux: Lint"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node:
- 10
- 12
- 14
- 16
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
cache: npm
- run: npm ci
- run: npm run lint
- run: |
npm run commitlint -- \
--verbose \
--from `git merge-base origin/master $GITHUB_SHA`
8 changes: 2 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
linux:
name: "Node ${{ matrix.node }} on Linux: Test and Lint"
name: "Node ${{ matrix.node }} on Linux: Test"
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand All @@ -27,16 +27,12 @@ jobs:
node-version: ${{ matrix.node }}
cache: npm
- run: npm ci
- run: |
npm run commitlint -- \
--verbose \
--from `git merge-base origin/master $GITHUB_SHA`
- run: npm run build
- run: npm run test:unit
- run: npm run test:e2e
- run: npm run test:integration
windows:
name: "Node ${{ matrix.node }} on Windows: Test and Lint"
name: "Node ${{ matrix.node }} on Windows: Test"
runs-on: windows-latest
defaults:
run:
Expand Down

0 comments on commit 394ba52

Please sign in to comment.