fix: [capricorn86#1151] Add newline if it's a block/flex element and …

…there's more content coming after
karpiuMG · Feb 28, 2025 · 71b0837 · 71b0837
1 parent a8bcdd4
commit 71b0837
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/happy-dom/src/nodes/html-element/HTMLElement.ts b/packages/happy-dom/src/nodes/html-element/HTMLElement.ts
@@ -239,7 +239,7 @@ export default class HTMLElement extends Element {
 						const textTransform = computedStyle.textTransform;
 
 						// Only add newline if it's a block/flex element and there's more content coming after
-						if ((display === 'block' || display === 'flex') && result) {
+						if ((display === 'block' || display === 'flex') && result && childElement.innerText) {
 							result += '\n';
 						}
 

diff --git a/packages/happy-dom/test/nodes/html-element/HTMLElement.test.ts b/packages/happy-dom/test/nodes/html-element/HTMLElement.test.ts
@@ -144,9 +144,10 @@ describe('HTMLElement', () => {
 			expect(element.innerText).toBe('The quick brown fox\nJumped Over The Lazy Dog');
 		});
 
-		it('It skips svg elements when innerText is used', () => {
+		it("It skips svg elements when innerText is used and add a newline only if there's more content coming after", () => {
 			document.body.appendChild(element);
-			element.innerHTML = '<div><span><svg></svg></span>123</div>';
+			// notice the lack of closing div tag
+			element.innerHTML = '<div><span><svg></svg></span>123<div>';
 			expect(element.innerText).toBe('123');
 		});
 	});