Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Add network stats #535

Closed
ZeroMagic opened this issue Apr 17, 2019 · 2 comments
Closed

Add network stats #535

ZeroMagic opened this issue Apr 17, 2019 · 2 comments

Comments

@ZeroMagic
Copy link
Contributor

ZeroMagic commented Apr 17, 2019 •
edited
Loading

Description of problem

Currently KataContainers collect the stats from libcontainer Stats() API.

The libcontainer Stats() API has collected the network stats. However KataContainers do not transfer the network stats now. Can we add network stats ? The network stats will help us to improve our service quality.

message NetworkStats {
	string name = 1;
	uint64 RxBytes = 2;
	uint64 RxPackets = 3;
	uint64 RxErrors = 4;
	uint64 RxDropped = 5;
	uint64 TxBytes = 6;
	uint64 TxPackets = 7;
	uint64 TxErrors = 8;
	uint64 TxDropped = 9;
}

Expected result

kata-agent will transfer the network stats to kata-runtime. Then I will also do some work in kata-runtime to convert vc.ContainerStats to containerd/cgroups.Metrics. I have proposed a pull request in containerd/cgroups repo. containerd/cgroups#81
@bergwolf
Copy link
Member

Looks good! We can proceed once containerd merges containerd/cgroups#81

@ZeroMagic
Copy link
Contributor Author

Ok. We can wait for the merging to be completed

@ZeroMagic ZeroMagic mentioned this issue Apr 18, 2019
Merged
ZeroMagic added a commit to ZeroMagic/agent that referenced this issue Apr 18, 2019
@ZeroMagic
proto: add network stats
2cac193 
So that agent can transfer network stats to runtime

Fixes: kata-containers#535

Signed-off-by: ZeroMagic <[email protected]>
ZeroMagic added a commit to ZeroMagic/agent that referenced this issue Apr 18, 2019
@ZeroMagic
proto: add network stats
0095e7e 
So that agent can transfer network stats to runtime

Fixes: kata-containers#535

Signed-off-by: ZeroMagic <[email protected]>
ZeroMagic added a commit to ZeroMagic/agent that referenced this issue Apr 19, 2019
@ZeroMagic
proto: add network stats
441d0b0 
So that agent can transfer network stats to runtime

Fixes: kata-containers#535

Signed-off-by: ZeroMagic <[email protected]>
ZeroMagic added a commit to ZeroMagic/agent that referenced this issue Apr 19, 2019
@ZeroMagic
proto: add network stats
57b87a0 
So that agent can transfer network stats to runtime

Fixes: kata-containers#535

Signed-off-by: ZeroMagic <[email protected]>
@devimc devimc closed this as completed in d9aa453 Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bergwolf @ZeroMagic