Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __all__ to export classes properly #52

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Add __all__ to export classes properly #52

merged 1 commit into from
Nov 19, 2022

Conversation

parmenashp
Copy link
Contributor

@parmenashp parmenashp commented Nov 9, 2022

This PR resolves #48

@donovancarmona
Copy link

@kazhala could you review this PR?

@kazhala
Copy link
Owner

kazhala commented Nov 18, 2022

Hey hey, yep will have a look tmr. Been very busy lately. Apologies for the silence.

Copy link
Owner

@kazhala kazhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@kazhala kazhala merged commit 7513478 into kazhala:master Nov 19, 2022
@parmenashp parmenashp deleted the feat-export-classes branch November 19, 2022 02:13
brody4hire pushed a commit to brody4hire/InquirerLib that referenced this pull request Jan 16, 2024
Including some proposed & unpublished updates from InquirerPy:

- kazhala/InquirerPy#69 - fix typos
- kazhala/InquirerPy#65 - add DataValidator class
- kazhala/InquirerPy#56 - add Choice.instruction field
- kazhala/InquirerPy#52 - proper exporting of functions ref:
  - kazhala/InquirerPy#60
  - kazhala/InquirerPy#48

also document some info to address issue: kazhala/InquirerPy#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inquirer.py is not properly exporting functions
3 participants