Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultReadN should be documented as intended for single-threaded use #8

Closed
edsko opened this issue Jul 2, 2024 · 1 comment · Fixed by #10
Closed

defaultReadN should be documented as intended for single-threaded use #8

edsko opened this issue Jul 2, 2024 · 1 comment · Fixed by #10

Comments

@edsko
Copy link
Collaborator

edsko commented Jul 2, 2024

This is a very minor issue, but it might be good to document that defaultReadN is intended for single-threaded usage only. (In http2 this is the case because it's only the frame receiving thread that is using it.)
@kazu-yamamoto
Copy link
Owner

Good point.
A PR is welcome!

edsko added a commit to edsko/http-semantics that referenced this issue Jul 18, 2024
@edsko
Mention that defaultReadN is not thread safe
b686129 
Closes kazu-yamamoto#8.
@edsko edsko mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention that defaultReadN is not thread safe edsko/http-semantics
2 participants
@kazu-yamamoto @edsko