Fix: result's index should be original list index

[dumin]

when i try this example: http://moonjs.ga/examples/search/index.html
i tap 'catch' but result list is not what i want

because after pipeline, some item may be removed because of zero length, so the index in result is not the original list index

so we can record index map (if need) to fix this problem

[kbrsh]

This looks good, but I think that this can be accomplished in a simpler manner. Wade.process returns false if the entry has a length of 0. The indexing doesn't have a clue, so I think we can use a sparse array, and if the value is undefined, then then skip over it, that way the index is correct.

[dumin]

yes, method you mentioned is better

[kbrsh]

Will you be updating the PR, or should I get to work on this?

[dumin]

I think i hava done, but not sure my PR update operation is correct

[kbrsh]

It looks good, but when filling normalizedData you can just do something like:

if(item !== false) {
  normalizedData[i] = item;
}

This is because when initializing an array with new Array(), all of the elements are already undefined.

[kbrsh]

Alright, since this has been inactive for a while, I'll try implementing it. Thanks for the help!

[dumin]

Set new Array(len) just to tell the compiler the initial size of array, to avoid memory copy in the dynamic expansion
I used to define every elements of this array, otherwise it would be skipped when use forEach / map function, this may cause other users to be troubled

E.g:

arr = new Array(10)
arr[4] = undefined
arr[5] = 'hello'

// forEach only touch element  4 & 5

[kbrsh]

Yeah, I know what new Array does. In this case you shouldn't really be needing to access the normalized data though. When accessed, it has a value of undefined. That's why I suggested merely skipping over it.

[leeoniya]

@kingpixil new is unnecessary; Array(len) works fine ;)