Add accessors to entry type. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the type of entries was parsed, there was no way for the library user to access it. This commit let the user access the `ty` field of the `KdlEntry` struct. It mirrors the accessors on the `value` field.
|
ahhh yep that was an oversight. Thank you! |
|
This is released now as [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Awesome library and markup language! I've been experimenting with it
and I think the
KdlEntrytype accessors were overlooked.While the type of entries was parsed, there was no way for the library
user to access it. It's part of the spec and I would expect to be able to
read it.