Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Redis Environment #133

Merged
merged 11 commits into from
Dec 30, 2024
Merged

Prepare Redis Environment #133

merged 11 commits into from
Dec 30, 2024

Conversation

JT2M0L3Y
Copy link
Collaborator

@JT2M0L3Y JT2M0L3Y commented Nov 2, 2024

Added

  • redis container has been added to the docker infrastructure (both the compose and manual setup).

Planned

  • store setup and run-time configurations as key-value pairs in redis in the form of DB as a cache.

@JT2M0L3Y JT2M0L3Y added enhancement New feature or request performance Performance issues between discord and ollama dependency Involves dependencies from npm or environments technical Non-business related labels Nov 2, 2024
@JT2M0L3Y JT2M0L3Y requested a review from kevinthedang November 2, 2024 22:26
@JT2M0L3Y JT2M0L3Y self-assigned this Nov 2, 2024
@JT2M0L3Y JT2M0L3Y linked an issue Nov 2, 2024 that may be closed by this pull request
Storing Data Using a Redis Database #57
Open
@JT2M0L3Y
Copy link
Collaborator Author

JT2M0L3Y commented Nov 2, 2024

image
image

kevinthedang
kevinthedang reviewed Nov 3, 2024
View reviewed changes
Copy link
Owner

@kevinthedang kevinthedang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for now. Left a couple comments.

@JT2M0L3Y JT2M0L3Y force-pushed the feature/redis-cache branch 2 times, most recently from a7cc98e to 33720fa Compare November 7, 2024 19:10
@JT2M0L3Y JT2M0L3Y removed the dependency Involves dependencies from npm or environments label Nov 7, 2024
@JT2M0L3Y JT2M0L3Y force-pushed the feature/redis-cache branch 2 times, most recently from 2dd8cc3 to b28b499 Compare November 9, 2024 04:12
@JT2M0L3Y
add redis container
b5e6f6b
@JT2M0L3Y
Updated Guides and Goals (#134)
957c360 
* Update README.md

* Update commands-guide.md

* Update events-guide.md

* Update commands-guide.md
@JT2M0L3Y JT2M0L3Y force-pushed the feature/redis-cache branch from b28b499 to 957c360 Compare December 17, 2024 00:04
@JT2M0L3Y JT2M0L3Y force-pushed the feature/redis-cache branch 2 times, most recently from b366c41 to b2adac1 Compare December 22, 2024 18:10
@JT2M0L3Y JT2M0L3Y force-pushed the feature/redis-cache branch from 28843ba to 2b9f9fa Compare December 22, 2024 19:04
@JT2M0L3Y
Copy link
Collaborator Author

JT2M0L3Y commented Dec 23, 2024 •
edited
Loading

Changed

  • added connection to a Redis client
  • added a mock redis object to the test harness for commands
  • updated npm packages, there were no big impediments (nothing used in this project was modified)

Planned

  • refactor config handlers to store kv-pairs in the Redis container instead of a volume tied to the discord container

cc: @kevinthedang

@kevinthedang kevinthedang added dependency Involves dependencies from npm or environments and removed technical Non-business related labels Dec 23, 2024
@JT2M0L3Y JT2M0L3Y removed a link to an issue Dec 23, 2024
Storing Data Using a Redis Database #57
Open
@JT2M0L3Y JT2M0L3Y changed the title Store Configuration in Redis Supplement Redis Containre Environment Dec 23, 2024
@JT2M0L3Y JT2M0L3Y changed the title Supplement Redis Containre Environment Initialize Redis Environment Dec 23, 2024
@JT2M0L3Y JT2M0L3Y marked this pull request as ready for review December 23, 2024 19:42
@JT2M0L3Y JT2M0L3Y force-pushed the feature/redis-cache branch from 2b9f9fa to 850f0d4 Compare December 23, 2024 19:45
@JT2M0L3Y
Copy link
Collaborator Author

JT2M0L3Y commented Dec 23, 2024 •
edited
Loading

Changed

  • added a requirement for npm version
  • updated node version used in containers

@JT2M0L3Y JT2M0L3Y mentioned this pull request Dec 23, 2024
Open
@JT2M0L3Y JT2M0L3Y linked an issue Dec 23, 2024 that may be closed by this pull request
End-of-life Approaching for Node Version #151
Closed
@JT2M0L3Y JT2M0L3Y changed the title Initialize Redis Environment Prepare Redis Environment Dec 24, 2024
@JT2M0L3Y @snyk-bot
fix: upgrade dotenv from 16.4.5 to 16.4.7 (#152)
c8c7f57 
Snyk has created this PR to upgrade dotenv from 16.4.5 to 16.4.7.

See this package in npm:
dotenv

See this project in Snyk:
https://app.snyk.io/org/jt2m0l3y/project/d8b070a3-e4a3-457a-977b-7eb6a4a48346?utm_source=github&utm_medium=referral&page=upgrade-pr

Co-authored-by: snyk-bot <[email protected]>
@JT2M0L3Y
Copy link
Collaborator Author

Hoping to do a pre-release of the Redis environment here, this work is ready to be reviewed.

cc: @kevinthedang

kevinthedang
kevinthedang reviewed Dec 30, 2024
View reviewed changes
@kevinthedang
Copy link
Owner

Also, it's chill to push multiple commits instead of force pushing some of the work to have the same commit name.

@JT2M0L3Y JT2M0L3Y merged commit 2ea77c9 into master Dec 30, 2024
1 check passed
@JT2M0L3Y JT2M0L3Y deleted the feature/redis-cache branch December 30, 2024 23:53
@kevinthedang kevinthedang mentioned this pull request Dec 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthedang kevinthedang kevinthedang approved these changes

Assignees

@JT2M0L3Y JT2M0L3Y

Labels
dependency Involves dependencies from npm or environments enhancement New feature or request performance Performance issues between discord and ollama
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End-of-life Approaching for Node Version
2 participants
@JT2M0L3Y @kevinthedang