Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull and Switch Model Revised #142

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Pull and Switch Model Revised #142

merged 4 commits into from
Dec 5, 2024

Conversation

kevinthedang
Copy link
Owner

Changes

  • The pull-model command is not a admin command. It will notify non-admin users to contact admins to use it.
  • The switch-model command will no longer be allowed to pull models directly from the ollama library due to possible concerns with storage.
  • Made responses from the bot a little less technical for some users.

Notes

  • This addresses some issues found in Pull/Switch commands can waste hard drive space and lack admin permissions #141. It might be wise to have some kind of "default model" if all else fails and to just get right into using the bot. It would not be an issue to implement in the future.
  • New issue will probably be made for streamlining first setup for the bot. So, when a user first talks, it will set up everything! Server preferences, the User's preference, and pull the designated "default" model. If there is no "default" model then a backup default will be set if not set.
  • Another Issue is likely getting rid of the "embed" style as then it will seem more like a regular user.

@kevinthedang kevinthedang added the patch Application fixes label Dec 5, 2024
@kevinthedang kevinthedang self-assigned this Dec 5, 2024
@kevinthedang kevinthedang linked an issue Dec 5, 2024 that may be closed by this pull request
Pull/Switch commands can waste hard drive space and lack admin permissions #141
Closed
@kevinthedang kevinthedang mentioned this pull request Dec 5, 2024
Closed
@kevinthedang kevinthedang merged commit d570a50 into master Dec 5, 2024
1 check passed
@kevinthedang kevinthedang deleted the patch/model-pull-restrictions branch December 5, 2024 05:29
kevinthedang added a commit that referenced this pull request Dec 11, 2024
@kevinthedang
Squashed commit of the following:
6802af9 
commit d570a50
Author: Kevin Dang <[email protected]>
Date:   Wed Dec 4 21:29:01 2024 -0800

    Pull and Switch Model Revised (#142)

    * Update: pull-model only runnable by admins now

    * Update: switch-model cannot pull models anymore

    * Update: less technical responses

    * Update: version increment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JT2M0L3Y JT2M0L3Y JT2M0L3Y approved these changes

Assignees

@kevinthedang kevinthedang

Labels
patch Application fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull/Switch commands can waste hard drive space and lack admin permissions
2 participants
@kevinthedang @JT2M0L3Y