fix(developer): adds utility script to facilitate Developer-build Lerna compatibility #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahorton
changed the title
This was referenced May 12, 2020
|
While not yet merged, we've decided to move ahead with the approach of #3119. Closing this PR now in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is intended as a patch-PR for an issue noted in #3071. Feel free to automatically approve + merge it at any point if the patch seems acceptable.
Now that we're transitioning toward use of
lernafor NPM dependency installs, our build scripts no longer manually create npm links. This affects the build script for Developer,npm installwould attempt to install now-listed dependencies that aren't actually npm published and/or are not yet published (eg: test builds).Since
npm installignores any packages that would install overnpm linksites, simply preserving thenpmlinks across anode_modulesfolder wipe keeps the Developer script happy. It just takes a bit of work to actually auto-detect and preserve them.