-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All the new Monorepo things #1727
Merged
+917
−2,208
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
fa183a3
Progress
emmatown 5a0150a
More stuff changed
emmatown b36b1e7
Run manypkg fix
emmatown 23febf9
Add manypkg to prepare script
emmatown 8c3dbae
Upgrade preconstruct
emmatown e692ec5
Update yarn.lock
emmatown 4690f94
All but two usages of bolt are gone :tada:
emmatown 9464734
Maybe make a thing work
emmatown f2f4ea2
Replace bolt ws exec with manypkg exec
emmatown 42ead13
Fix a thing probably
emmatown 7df4077
Merge branch 'master' into new-monorepo-things
emmatown 9a39fb7
pls work cypress
emmatown 4d6abd9
Upgrade babel things and deduplicate them
emmatown 1bf4f18
Update netlify.toml
emmatown 4187ab7
Merge branch 'master' into new-monorepo-things
emmatown 2a36382
Yarn is included now
emmatown 62b63d5
I just want netlify to work
emmatown d16c596
Maybe this'll fix it
emmatown 093aa18
whoops
emmatown 6fd3e25
pls just work
emmatown ce39f1a
maybe this'll work
emmatown 7ebadb9
Merge branch 'master' into new-monorepo-things
emmatown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,8 @@ | ||
|
||
# Changesets | ||
|
||
Hello and welcome! This folder has been automatically generated by `@atlaskit/build-releases`, a build tool that works with `bolt` to help you release components from a mono-repository. You can find the full documentation for it [here](https://www.npmjs.com/package/@atlaskit/build-releases) | ||
|
||
To help you get started though, here are some things you should know about this folder: | ||
|
||
## Changesets are automatically generated | ||
|
||
Changesets are generated by the `build-releases changeset` command, though it may have been given a new name within your repository. As long as you are following a changeset release flow, you shouldn't have any problems. | ||
|
||
## Each changeset is its own folder | ||
|
||
We use hashes by default for these folder names to avoid collisions when generating them, but there's no harm that will come from renaming them. | ||
|
||
## Changesets are automatically removed | ||
|
||
When `build-releases version` or equivalent command is run, all the changeset folders are removed. This is so we only ever use a changeset once. This makes this a very bad place to store any other information. | ||
|
||
## Changesets come in two parts | ||
|
||
You should treat these parts quite differently: | ||
|
||
- `changes.md` is a file you should feel free to edit as much as you want. It will be prepended to your changelog when you next run your version command. | ||
- `changes.json` is a file that includes information about releases, what should be versioned by the version command. We strongly recommend against editing this directly, as you may make a new changeset that puts your bolt repository into an invalid state. | ||
|
||
## I want to edit the information in a `changes.json` - how do I do it safely? | ||
|
||
The best option is to make a new changeset using the changeset command, copy over the `changes.md`, then delete the old changeset. | ||
|
||
## Can I rename the folder for my changeset? | ||
|
||
Absolutely! We need unique hashes to make changesets play nicely with git, but changing your folder from our hash to your own name isn't going to cause any problems. | ||
|
||
## Can I manually delete changesets? | ||
Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works | ||
with multi-package repos, or single-package repos to help you version and publish your code. You can | ||
find the full documentation for it [in our repository](https://github.com/changesets/changesets) | ||
|
||
You can, but you should be aware this will remove the intent to release communicated by the changeset, and should be done with caution. | ||
We have a quick list of common questions to get you started engaging with this project in | ||
[our documentation](https://github.com/changesets/changesets/blob/master/docs/common-questions.md) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json", | ||
"changelog": "./getChangelogEntry", | ||
"commit": false, | ||
"linked": [], | ||
"access": "public" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
const { getInfo } = require('@changesets/get-github-info'); | ||
|
||
const getReleaseLine = async (changeset, type) => { | ||
const [firstLine, ...futureLines] = changeset.summary | ||
.split('\n') | ||
.map(l => l.trimRight()); | ||
const { links } = await getInfo({ | ||
repo: 'keystonejs/keystone-5', | ||
commit: changeset.commit, | ||
}); | ||
return `- ${links.commit}${links.pull === null ? '' : ` ${links.pull}`}${ | ||
links.user === null ? '' : ` Thanks ${links.user}!` | ||
} - ${firstLine}\n${futureLines.map(l => ` ${l}`).join('\n')}`; | ||
}; | ||
|
||
const getDependencyReleaseLine = async (changesets, dependenciesUpdated) => { | ||
if (dependenciesUpdated.length === 0) return ''; | ||
const { links } = await getInfo({ | ||
repo: 'keystonejs/keystone-5', | ||
commit: changeset.commit, | ||
}); | ||
|
||
const changesetLinks = changesets.map( | ||
changeset => `- Updated dependencies [${links.commit}]:` | ||
); | ||
|
||
const updatedDepenenciesList = dependenciesUpdated.map( | ||
dependency => ` - ${dependency.name}@${dependency.version}` | ||
); | ||
|
||
return [...changesetLinks, ...updatedDepenenciesList].join('\n'); | ||
}; | ||
|
||
module.exports = { | ||
getReleaseLine, | ||
getDependencyReleaseLine, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏