-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add triangle latency summand #18
Conversation
f176ccd
to
ea9d51b
Compare
Thank you for implementing both of them! #17 just got merged Good catch on that |
ea9d51b
to
66a00b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to prepare this PR. I've included my remarks regarding potential simplification of the triangle wave function. Let me know if you would like to refactor it. If not - no worries, this is by no means obligatory.
66a00b8
to
15028ae
Compare
BREAKING CHANGE: Regarding only the improvement in LatencyCfg
15028ae
to
007a992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for introducing the changes.
What was done in this PR:
Additionally:
expected
is passed first, andactual
value is the last arg)sawAmplitute
->sawAmplitude
Resolves #19