Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CODEOWNERS #79

wants to merge 1 commit into from

Conversation

craigbox
Copy link
Contributor

add myself to org owners for approving membership requests.

(I would probably consider removing Idit but I'll leave that up to her)

Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @craigbox, the PR is effectively requesting org admin permissions. IMO this repo should just have the 2 main roles: maintain the markdown and org admin. Having a middle ground where you have the power of org admin but are not listed as such is something I don't think we should pursue.

#58 shows the full request for org admin

@craigbox
Copy link
Contributor Author

Doesn't this just apply to the community repo?

Based on my experience with Istio, I do a lot of approval in community and docs repos, and want no special privileges beyond that.

@ilrudie
Copy link
Contributor

ilrudie commented Feb 19, 2025

The request you made allows you CODEOWNER control over org automation and scripts for the entirety of kgateway-dev. It's been restricted to folks who are already org admins because approval of org.yaml changes is ~equivalent IMO. You currently have permission to review approve (most) markdown changes in the community repo.

It's a fair point though, should we just allow that community-maintainer has a super high level of power because it has control over the automation of the org and not try to draw a line between "maintains markdown for the community" and "maintains the community full stop, including who is in/out and what roles they posses"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants