Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-277: Backer cannot comment on updates #1444

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Bring back the check around the current user being a backer

🤔 Why

  • we recently added the field canComment to the project, it works perfectly for comments on a project. We did not had in mind though the comments on updates.

👀 See

commentsUpdates.mp4

Trello, screenshots, external resources?

Before 🐛 After 🦋

📋 QA

  • Try to comment as a backer into a update from the project page
  • Try to comment as a backer into a update from the activities page
  • Check that you cannot comment on any update or project in which you are not backer

Story 📖

NTV-277

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1444 (649871a) into master (bca17c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1444   +/-   ##
=========================================
  Coverage     72.28%   72.28%           
  Complexity      736      736           
=========================================
  Files           210      210           
  Lines          6083     6083           
  Branches        391      391           
=========================================
  Hits           4397     4397           
  Misses         1548     1548           
  Partials        138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca17c5...649871a. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review November 3, 2021 19:20
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arkariang Arkariang merged commit de2ea04 into master Nov 3, 2021
@Arkariang Arkariang deleted the imartin/NTV-277 branch November 3, 2021 19:49
Arkariang added a commit that referenced this pull request Nov 3, 2021
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-277: Collaborator & Baker can comment on project updates and project (#1446)
  NTV-277: Backer cannot comment on updates  (#1444)
  [no-jira]: Update fastlane (#1440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants