-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NT-232: Convert the ProjectUtils.java class to a Kotlin extension #1453
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
============================================
+ Coverage 72.29% 72.34% +0.05%
+ Complexity 736 710 -26
============================================
Files 210 209 -1
Lines 6082 6028 -54
Branches 391 375 -16
============================================
- Hits 4397 4361 -36
+ Misses 1547 1532 -15
+ Partials 138 135 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! great work @leighdouglas ❤️
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-280: Cannot edit a pledge with a sold out reward on a project with add-ons (#1454) NT-232: Convert the ProjectUtils.java class to a Kotlin extension (#1453) Remove old awareness component for experiment variant (#1456)
📲 What
ProjectUtils.java
->ProjectExt.kt
🤔 Why
Ongoing effort to migrate codebase to kotlin
👀 See
No external/user facing changes
📋 QA
Story 📖
NT-232: Convert the ProjectUtils.java class to a Kotlin extension