Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT-232: Convert the ProjectUtils.java class to a Kotlin extension #1453

Merged
merged 12 commits into from
Nov 16, 2021

Conversation

leighdouglas
Copy link
Contributor

📲 What

  • Refactored ProjectUtils.java -> ProjectExt.kt
  • Created a new test suite
  • Refactor usages of ProjectUtils.java methods to use the new extension methods instead

🤔 Why

Ongoing effort to migrate codebase to kotlin

👀 See

No external/user facing changes

📋 QA

  • Should probably do a full regression to make sure everything is working as it should, as these methods touch several parts of the product

Story 📖

NT-232: Convert the ProjectUtils.java class to a Kotlin extension

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1453 (257dab3) into master (69792b4) will increase coverage by 0.05%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1453      +/-   ##
============================================
+ Coverage     72.29%   72.34%   +0.05%     
+ Complexity      736      710      -26     
============================================
  Files           210      209       -1     
  Lines          6082     6028      -54     
  Branches        391      375      -16     
============================================
- Hits           4397     4361      -36     
+ Misses         1547     1532      -15     
+ Partials        138      135       -3     
Impacted Files Coverage Δ
...ava/com/kickstarter/ui/adapters/ThanksAdapter.java 0.00% <0.00%> (ø)
...n/java/com/kickstarter/libs/utils/RefTagUtils.java 76.74% <100.00%> (ø)
...wmodels/CreatorDashboardHeaderHolderViewModel.java 98.73% <100.00%> (ø)
...starter/viewmodels/ProjectCardHolderViewModel.java 97.28% <100.00%> (ø)
...kickstarter/viewmodels/ProjectHolderViewModel.java 98.65% <100.00%> (ø)
...viewmodels/ProjectSearchResultHolderViewModel.java 96.77% <100.00%> (ø)
...com/kickstarter/mock/factories/ProjectFactory.java 88.09% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69792b4...257dab3. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! great work @leighdouglas ❤️

@leighdouglas leighdouglas merged commit bd8f8d8 into master Nov 16, 2021
@leighdouglas leighdouglas deleted the leigh/ntv-232-project-ext branch November 16, 2021 16:47
Arkariang added a commit that referenced this pull request Nov 16, 2021
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-280: Cannot edit a pledge with a sold out reward on a project with add-ons (#1454)
  NT-232: Convert the ProjectUtils.java class to a Kotlin extension (#1453)
  Remove old awareness component for experiment variant (#1456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants