Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-298:Layout breaking after entering pledge flow #1466

Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Nov 24, 2021

📲 What

Fix weird gap on the bottom of the screen

🛠 How

Calculate animation

👀 See

device-2021-11-24-191846.mp4

📋 QA

  1. Open a project on the new Project screen
  2. Tap Back this project
  3. Notice there's a weird gap on the bottom of the screen

Story 📖

https://kickstarter.atlassian.net/browse/NTV-298

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! what a ghost in there

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1466 (c283def) into master (a651e4f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1466   +/-   ##
=========================================
  Coverage     72.69%   72.69%           
  Complexity      711      711           
=========================================
  Files           209      209           
  Lines          6031     6031           
  Branches        375      375           
=========================================
  Hits           4384     4384           
  Misses         1512     1512           
  Partials        135      135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a651e4f...c283def. Read the comment docs.

@hadia hadia merged commit 803b2fb into master Nov 24, 2021
@hadia hadia deleted the hadia/NTV-298_Layout_breaking_after_entering_pledge_flow branch November 24, 2021 18:49
Arkariang added a commit that referenced this pull request Nov 25, 2021
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-298:Layout breaking after entering pledge flow (#1466)
Arkariang added a commit that referenced this pull request Nov 25, 2021
…r/android-oss into imartin/NTV-267-TextElementsUI

* 'feature/NTV-188-Project-Story' of github.com:kickstarter/android-oss:
  NTV-298:Layout breaking after entering pledge flow (#1466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants