Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira: one more flacky test related to DateTime.now() #1479

Merged
merged 1 commit into from
Dec 8, 2021
Merged

no-jira: one more flacky test related to DateTime.now() #1479

merged 1 commit into from
Dec 8, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

The test testDeadlineCountdown_shouldReturnCorrectString failed from time to time

🛠 How

  • Added a few milliseconds to allow processing time

👀 See

  • No user facing changes
    | | |

📋 QA

  • Execute several times the test testDeadlineCountdown_shouldReturnCorrectString should never fail

leighdouglas
leighdouglas approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🎉

@codecov
Copy link

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #1479 (97c81a6) into master (4733e10) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1479   +/-   ##
=========================================
  Coverage     72.69%   72.69%           
  Complexity      711      711           
=========================================
  Files           209      209           
  Lines          6031     6031           
  Branches        375      375           
=========================================
  Hits           4384     4384           
  Misses         1512     1512           
  Partials        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4733e10...97c81a6. Read the comment docs.

@Arkariang Arkariang merged commit 748c7e2 into master Dec 8, 2021
@Arkariang Arkariang deleted the imartin/last-flacky-test branch December 8, 2021 17:29
Arkariang added a commit that referenced this pull request Dec 8, 2021
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
1ec54ef 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  no-jira: one more flacky test related to DateTime.now() (#1479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@hadia hadia Awaiting requested review from hadia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @leighdouglas