Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-320: migrate to kotlin preferences package #1489

Merged
merged 6 commits into from
Dec 16, 2021
Merged

NTV-320: migrate to kotlin preferences package #1489

merged 6 commits into from
Dec 16, 2021

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Migrated to kotlin the entire preferences package

Screen Shot 2021-12-16 at 4 45 42 PM

- Added new class `BooleanDataStore` as experiment, it uses jetpack `Preferences DataStore` internally. - In next tickest if the investigation goes well `BooleanPreferences` class will be substituted by `BooleanDataStore`

👀 See

  • No user facing changes

| | |

📋 QA

  • Delete cache and all storaged data from the app, log again, all should keep working as usual.

Story 📖

NTV-320

@codecov
Copy link

codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #1489 (5aa3cec) into master (b32fa06) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1489      +/-   ##
============================================
- Coverage     72.69%   72.66%   -0.03%     
+ Complexity      711      699      -12     
============================================
  Files           209      206       -3     
  Lines          6031     5992      -39     
  Branches        375      375              
============================================
- Hits           4384     4354      -30     
+ Misses         1512     1503       -9     
  Partials        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32fa06...5aa3cec. Read the comment docs.

@Arkariang Arkariang marked this pull request as ready for review December 16, 2021 16:02
@Arkariang Arkariang added the migration Migration Java to Kotlin label Dec 16, 2021
hadia
hadia approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@Arkariang Arkariang merged commit b0ed1e7 into master Dec 16, 2021
@Arkariang Arkariang deleted the imartin/NTV-320-migrate-to-kotlin branch December 16, 2021 17:54
Arkariang added a commit that referenced this pull request Dec 16, 2021
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
ba86967 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  NTV-320: migrate to kotlin preferences package (#1489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadia hadia hadia approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees
No one assigned
Labels
migration Migration Java to Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @hadia