Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-jira]: Bug on UI #1506

Merged
merged 4 commits into from
Jan 11, 2022
Merged

[no-jira]: Bug on UI #1506

merged 4 commits into from
Jan 11, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

  • On large screens (pixel 6 pro in this case), the animation to expand the pledge fragment was not having in account the status bar, leaving a blank space on the bottom.

👀 See

Screen Shot 2022-01-10 at 5 10 19 PM

| | |

📋 QA

  • Load the app on several simulator with several screen images,

@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #1506 (c75fb99) into master (0a59f87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1506   +/-   ##
=========================================
  Coverage     71.80%   71.80%           
  Complexity      542      542           
=========================================
  Files           186      186           
  Lines          5447     5447           
  Branches        287      287           
=========================================
  Hits           3911     3911           
  Misses         1454     1454           
  Partials         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a59f87...c75fb99. Read the comment docs.

hadia
hadia approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on emulator working fine 😍

@Arkariang Arkariang merged commit cf41f72 into master Jan 11, 2022
@Arkariang Arkariang deleted the imartin/fix-bug-ui branch January 11, 2022 18:06
Arkariang added a commit that referenced this pull request Jan 11, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
4200359 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  [no-jira]: Bug on UI  (#1506)
  NTV-337: PaymentSource Model (#1504)
  NTV-306 : Migrate to Kotlin Extension Discovery Utils classes (#1496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadia hadia hadia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @hadia