Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No-jira]: Added test for GraphQLTransformers #1520

Merged
merged 5 commits into from
Jan 20, 2022
Merged

[No-jira]: Added test for GraphQLTransformers #1520

merged 5 commits into from
Jan 20, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Renamed function
  • Added test

📋 QA

  • run the tests, no user facing changes

@codecov
Copy link

codecov bot commented Jan 19, 2022 •
edited
Loading

Codecov Report

Merging #1520 (c14353b) into master (92be27f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1520   +/-   ##
=========================================
  Coverage     69.26%   69.26%           
  Complexity      451      451           
=========================================
  Files           177      177           
  Lines          4805     4805           
  Branches        285      285           
=========================================
  Hits           3328     3328           
  Misses         1397     1397           
  Partials         80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92be27f...c14353b. Read the comment docs.

leighdouglas
leighdouglas approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🎉

@Arkariang Arkariang merged commit 25e983f into master Jan 20, 2022
@Arkariang Arkariang deleted the imartin/refactor-testing branch January 20, 2022 17:13
Arkariang added a commit that referenced this pull request Jan 20, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into feat…
f9d0326 
…ure/NTV-188-Project-Story

* 'master' of github.com:kickstarter/android-oss:
  [No-jira]: Added test for GraphQLTransformers (#1520)
  NTV-327: Copy formatting Errors (#1519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkariang @leighdouglas @hadia