Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-475: Migrate XauthBody.java to kotlin and deprecate Autoparcel #1593

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Apr 6, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

📋 QA

Test login with 2FA

Story 📖

https://kickstarter.atlassian.net/browse/NTV-475

@hadia hadia added the migration Migration Java to Kotlin label Apr 6, 2022
@hadia hadia requested review from Arkariang and leighdouglas April 6, 2022 15:31
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1593 (f5dbbec) into master (2ba954b) will increase coverage by 0.05%.
The diff coverage is 96.96%.

@@             Coverage Diff              @@
##             master    #1593      +/-   ##
============================================
+ Coverage     77.46%   77.51%   +0.05%     
- Complexity     1656     1665       +9     
============================================
  Files           356      356              
  Lines         15218    15248      +30     
  Branches       1717     1721       +4     
============================================
+ Hits          11788    11820      +32     
+ Misses         2509     2506       -3     
- Partials        921      922       +1     
Impacted Files Coverage Δ
.../com/kickstarter/services/apirequests/XauthBody.kt 96.96% <96.96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba954b...f5dbbec. Read the comment docs.

@hadia hadia merged commit 0d41bea into master Apr 7, 2022
@hadia hadia deleted the hadia/NTV-475_Migrate_XauthBody branch April 7, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants