Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-491:Deprecate Autoparcel for StoredCard.kt #1596

Merged
merged 8 commits into from
Apr 13, 2022
Merged

NTV-491:Deprecate Autoparcel for StoredCard.kt #1596

merged 8 commits into from
Apr 13, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Apr 11, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

Uploading device-2022-04-11-153859.mp4…

📋 QA

test Stored payment cards

Story 📖

https://kickstarter.atlassian.net/browse/NTV-491

Deprecate Autoparcel for StoredCard.kt
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1596 (a95620a) into master (4741550) will increase coverage by 0.12%.
The diff coverage is 94.33%.

@@             Coverage Diff              @@
##             master    #1596      +/-   ##
============================================
+ Coverage     77.63%   77.75%   +0.12%     
- Complexity     1721     1732      +11     
============================================
  Files           356      356              
  Lines         15581    15617      +36     
  Branches       1793     1798       +5     
============================================
+ Hits          12096    12143      +47     
+ Misses         2519     2508      -11     
  Partials        966      966              
Impacted Files Coverage Δ
...src/main/java/com/kickstarter/models/StoredCard.kt 94.91% <92.68%> (+55.78%) ⬆️
...om/kickstarter/mock/factories/StoredCardFactory.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4741550...a95620a. Read the comment docs.

@hadia hadia merged commit 79768db into master Apr 13, 2022
@hadia hadia deleted the hadia/NTV-491 branch April 13, 2022 23:32
Arkariang added a commit that referenced this pull request Apr 14, 2022
…tin/pay-1420-migrate-to-graph

* 'master' of github.com:kickstarter/android-oss:
  NTV-469: Migrate PushTokenBody.java to kotlin and deprecate Autoparcel (#1602)
  NTV-442 : Migrate ActivityEnvelope.java to kotlin and deprecate Autoparcel (#1600)
  NTV-491:Deprecate Autoparcel for StoredCard.kt (#1596)
  NTV-490: Migrate ActivityResult.java to kotlin and deprecate Autoparcel (#1603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants