Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-494: Deprecate Autoparcel for ProjectData.kt #1609

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Apr 18, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

Screen Shot 2022-04-18 at 5 14 57 PM

📋 QA

test Project data parameter in segment events

Story 📖

https://kickstarter.atlassian.net/browse/NTV-494

@hadia hadia requested review from Arkariang and leighdouglas April 18, 2022 15:17
@hadia hadia added maintenance 🗜 migration Migration Java to Kotlin labels Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1609 (700bc12) into master (72229be) will increase coverage by 0.04%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##             master    #1609      +/-   ##
============================================
+ Coverage     77.93%   77.98%   +0.04%     
- Complexity     1756     1770      +14     
============================================
  Files           356      356              
  Lines         15836    15879      +43     
  Branches       1828     1834       +6     
============================================
+ Hits          12342    12383      +41     
- Misses         2510     2511       +1     
- Partials        984      985       +1     
Impacted Files Coverage Δ
...c/main/java/com/kickstarter/ui/data/ProjectData.kt 91.66% <91.66%> (-8.34%) ⬇️
...m/kickstarter/mock/factories/ProjectDataFactory.kt 100.00% <100.00%> (ø)
...src/main/java/com/kickstarter/models/StoredCard.kt 94.91% <0.00%> (ø)
...pp/src/main/java/com/kickstarter/models/Project.kt 77.41% <0.00%> (+0.25%) ⬆️
app/src/main/java/com/kickstarter/libs/RefTag.kt 97.91% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72229be...700bc12. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hadia hadia merged commit e94c9c3 into master Apr 19, 2022
@hadia hadia deleted the hadia/NTV-494 branch April 19, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 migration Migration Java to Kotlin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants