Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1746: Hook up alert dot to v1 user field #2136

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Sep 25, 2024

📲 What

  • ppoHasAction wasn't populating because it has a different format on the backend than what our parser is serializing for (it is camelCase instead of being snake_case)
  • Also fixed the issue where the red dot notification on the hamburger button in the discovery toolbar was only showing after the first login.

🤔 Why

users should know when they have pledges to fix

🛠 How

  • Just added the @SerializedName("ppoHasAction") annotation to fix the issue, but in the future the backend should modify this field to be snake case (or we can just use graph at that point hopefully lol)
  • It's a little iffy, but we were running into a race condition when trying to set the drawable for the hamburger icon. we just exposed another stream in the view model that will handle this, but when we migrate the discovery view model to rxjava 2 we can remove this

👀 See

Untitled Untitled1

📋 QA

If a user has PPO alerts, should see the red dot on the hamburger menu and in the menu next to project alerts. Also test this in darkmode to make sure colors are correct. try to test this with an account that doesnt have errored backings as this will also show the red dot hamburger menu button

Story 📖

MBL-1746: Hook up alert dot to v1 user field

@leighdouglas leighdouglas changed the title fix ppo has action field, adjust darkmode check MBL-1746: Hook up alert dot to v1 user field Sep 25, 2024
@leighdouglas leighdouglas force-pushed the leigh/mbl-1746-red-dot branch from 07575bb to a28b6c7 Compare October 2, 2024 17:10
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.78%. Comparing base (2c99cee) to head (a28b6c7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2136   +/-   ##
=========================================
  Coverage     67.77%   67.78%           
  Complexity     2234     2234           
=========================================
  Files           368      368           
  Lines         22884    22889    +5     
  Branches       3295     3294    -1     
=========================================
+ Hits          15510    15515    +5     
- Misses         5602     5603    +1     
+ Partials       1772     1771    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leighdouglas leighdouglas marked this pull request as ready for review October 3, 2024 15:26
@leighdouglas leighdouglas requested review from mtgriego and Arkariang and removed request for mtgriego October 3, 2024 15:26
@leighdouglas leighdouglas self-assigned this Oct 3, 2024
@leighdouglas leighdouglas merged commit 8552ca7 into master Oct 3, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1746-red-dot branch October 3, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants