MBL-1744: Refactor Fix Pledge Flow #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project page and manage pledge screens
Arkariang
commented
Oct 2, 2024
| @@ -175,6 +176,9 @@ class ProjectPageActivity : | |||
| env | |||
| } | |||
|
|
|||
| val ffClient = requireNotNull(environment?.featureFlagClient()) | |||
| ffClient.activate(this) | |||
There was a problem hiding this comment.
calling activate when the activity is loaded will minimize the fist installation gap when the information requested to firebase remote config has not yet been applied.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2142 +/- ##
============================================
+ Coverage 67.48% 67.50% +0.02%
- Complexity 2221 2222 +1
============================================
Files 368 368
Lines 22889 22893 +4
Branches 3294 3294
============================================
+ Hits 15446 15454 +8
+ Misses 5689 5685 -4
Partials 1754 1754 ☔ View full report in Codecov by Sentry. |
leighdouglas
reviewed
Oct 3, 2024
| @@ -441,9 +446,14 @@ class CrowdfundCheckoutViewModel(val environment: Environment, bundle: Bundle? = | |||
| selectedPaymentMethod | |||
| ) | |||
| } | |||
| PledgeReason.FIX_PLEDGE, // Managed on PledgeFragment/ViewModel | |||
| PledgeReason.FIX_PLEDGE -> { | |||
| // - Fix pledge should NOT send amounts/rewardId's/locationId ONLY selected paymentMethod | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Refactor of Fix Pledge flow
🤔 Why
CrowdfundCheckoutFragment/Viewmodel, if feature flag is off will still usePledgeFragment/ViewmodelPledgeFragment/ViewmodelPledgeFragmentViewModel🛠 How
CrowdfundViewModelUpdateBackingmutation only receivespaymentSourceIdwhen fixing a pledge.👀 See
FixPledgeFlowWorking.mp4
| | |
📋 QA
4000000000000341then get the project to collect, (the card will fail due to insufficient funds), and fix pledge flow will be available.Story 📖
MBL-1744