Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1767: SegmentTrackingClient migration to RXJava2 #2145

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Oct 4, 2024

📲 What

  • More RXJava2 migrations, this time the Analytics client

🤔 Why

👀 See

Screen.Recording.2024-10-04.at.11.08.21.AM.mov

| | |

📋 QA

  • Checkout this branch, run the app, then kill it, come back to foreground and make sure you are still sending events to segment, either check the segment dashboard or do any action that will trigger events like in the recorded video posted and check logcat.

Story 📖

MBL-1767

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.51%. Comparing base (eda7938) to head (c2cfdfc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...java/com/kickstarter/libs/SegmentTrackingClient.kt 83.33% 0 Missing and 1 partial ⚠️
...ckstarter/libs/braze/InAppCustomListenerHandler.kt 80.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2145      +/-   ##
============================================
+ Coverage     67.48%   67.51%   +0.02%     
- Complexity     2221     2225       +4     
============================================
  Files           368      368              
  Lines         22889    22897       +8     
  Branches       3294     3294              
============================================
+ Hits          15446    15458      +12     
+ Misses         5689     5684       -5     
- Partials       1754     1755       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang changed the title Imartin/mbl 1767 MBL-1767: SegmentTrackingClient migration to RXJava2 Oct 4, 2024
@Arkariang Arkariang self-assigned this Oct 4, 2024
@Arkariang Arkariang marked this pull request as ready for review October 4, 2024 21:18
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Arkariang Arkariang merged commit d061220 into master Oct 7, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1767 branch October 7, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants