MBL-1068: Remove RXJava1 and related dependencies from our source code. #2170
Conversation
…rd in Discovery solved
| .map { it.getValue() } | ||
| .skip(1) | ||
| .filter { `object`: User? -> `object`.isNotNull() } | ||
| .subscribe { u: User? -> |
There was a problem hiding this comment.
Subscription to the internal user observable is no longer needed. The user is persisted and emited on Login() method and refresh() method.
- Make sure the internal user observable is private and cannot have new emissions to the observable from outside `CurrentUser` object.
This reverts commit a4739f7.
| @@ -0,0 +1,15 @@ | |||
| package com.kickstarter.libs | |||
There was a problem hiding this comment.
Just migrated from Java to kotlin
| if (accessToken.isNotNull() && accessToken.isNotEmpty()) { | ||
| client.fetchCurrentUser() | ||
| .doOnError { | ||
| forceLogout(it.message ?: "") |
There was a problem hiding this comment.
When app comes back from background refresh the current logged in user. If any error happens force a logout.
| @@ -48,52 +48,56 @@ class DiscoveryPagerAdapter( | |||
| * Passes along root categories to its fragment position to help fetch appropriate projects. | |||
| */ | |||
| fun takeCategoriesForPosition(categories: List<Category>, position: Int) { | |||
| Observable.from(fragments) | |||
| Observable.fromIterable(fragments) | |||
There was a problem hiding this comment.
TODO: Quite sure we can get rid in the adapter of all the RXJava subscriptions. Seems the only goal of having an observable from a collection and operate on it instead of directly operating on the collection (by not having it be mutable) is to avoid concurrency issues.
Should create a ticket on our techDebt backlog to addres it outside the RXJava migration
| @@ -61,9 +61,9 @@ class RewardCardAdapter(private val delegate: Delegate) : KSAdapter() { | |||
| fun takeCards(cards: List<StoredCard>, project: Project) { | |||
| sections().clear() | |||
| addSection( | |||
| Observable.from(cards) | |||
| Observable.fromIterable(cards) | |||
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2170 +/- ##
============================================
+ Coverage 68.85% 68.97% +0.11%
+ Complexity 2225 2162 -63
============================================
Files 366 346 -20
Lines 23165 22845 -320
Branches 3360 3346 -14
============================================
- Hits 15951 15758 -193
+ Misses 5403 5288 -115
+ Partials 1811 1799 -12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
📲 What
Wrapping up a huge migration the android team started long ago.
Android architecture component ViewModel and Android architecture component Lifecycle was adopted to properly handle lifecyle.
All of these dependencies can be removed now regarding lifecycle, (even the authors of the libraries stopped using them a while back, if you wanna know more take a look here ):
Removed all helper dependencies to make Views become reactive. For Views we communicate with the VM via listeners, and RXJava2 migration has allowed us to use compose safely via
Completable.subscribeAsState
Removed retrofit wrapper for RXJava1 no longer needed
implementation "com.squareup.retrofit2:adapter-rxjava:$retrofit_version"Removed as well from the
Environmentobject all the RXJava1 versions for all the networking clients, User and Configuration objects etc ...🤔 Why
Migration completed!! It was done in small chunks:
👀 See
No user facing changes, this is the last piece for a very long ongoing migration :)
| | |
📋 QA
CurrentUser, log in, kill the app, and open the app again several times, you should not see any UI tied to logged out users.Story 📖
MBL-1068