MBL-2052 PLOT projects not working after scheme change on BE #2215
Conversation
jlplks
requested review from
leighdouglas,
Arkariang,
tonyteate and
ycheng-kickstarter
| @@ -277,7 +277,7 @@ class CrowdfundCheckoutViewModel(val environment: Environment, bundle: Bundle? = | |||
| emitCurrentState(isLoading = false) | |||
| } | |||
| .collectLatest { | |||
| showPlotWidget = it.projectIsPledgeOverTimeAllowed | |||
| showPlotWidget = !it.paymentIncrements.isNullOrEmpty() | |||
There was a problem hiding this comment.
Won't the payment increments be null or empty if the pledge doesn't meet the PLOT minimum? Fundamentally, the widget visibility should be toggled based on whether the project has been opted into PLOT, not on whether the payment increments exist.
There was a problem hiding this comment.
Yes, Fixed that on the next commit. Thanks for noticing it
|
QAed this and the PLOT widget does not appear when the pledge does not meet the PLOT minimum. See my comment above to fix this issue. Thanks for catching this! |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
=========================================
Coverage 68.35% 68.35%
+ Complexity 2200 2199 -1
=========================================
Files 352 352
Lines 23734 23726 -8
Branches 3483 3482 -1
=========================================
- Hits 16223 16219 -4
+ Misses 5676 5672 -4
Partials 1835 1835 ☔ View full report in Codecov by Sentry. |
📲 What
After a change on BE they remove the prop
projectIsPledgeOverTimeAllowedfrom PaymentPlan.We have to remove it from the project too.
🤔 Why
Can't pledge PLOT projects with PLOT becuase the component doesn't render do a validation with that prop.
🛠 How
Remove all the uses for that prop and change the only validation where it's used.
👀 See
| Before 🐛 |
| After 🦋 |
plot_fixed.webm
📋 QA
Enter with a valid user to staging an look for Crossfit Watch Hot Sauce
the project is a PLOT project so if you follow the PLOT flow you should see the PLOT component rendering correctly and have no problem to pledge it
Story 📖
MBL-2052 PLOT projects not working after scheme change on BE