Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Update #387

Merged
merged 13 commits into from
Nov 27, 2018
Merged

V3 Update #387

merged 13 commits into from
Nov 27, 2018

Conversation

Rcureton
Copy link
Contributor

What

  • Bringing v3 up to date with Master.

eoji and others added 13 commits November 6, 2018 16:41
…le (#372)

* added emailVerified field

* added fields to check if the email is verified

* added custom type mapping and mutation for userSendEmailVerification

* added send email verification mutuation and tests

* properly showing the send/re-send verification

* removed id field from graph since we're not using it

* made changes to viewmodel and tests

*  fixed view model tests

* added verficationError test, added verificationButton output

* renamed output

* renamed output again
* showing manual network error check

* added documentation for connection manager

* fixed checkstyle errors we're g2g

* fixed registering and unregistering our service

* removed unregister from onDestroy

* reverted line changes
* added register receiver to onPause

* removed register from onStart
* fixed display bug with currency

* fixed pledge amount text

* fixed spacing for symbols

* fixed formatting

* fixed reward viewmodel test

* fixed spacing and tests

* added method for rewardviewodel to kscurrency

* fixed reward pledge formatting

* refactored projectCurrencyOptions method and added test for non US currency

* fixed checkstyle error

* fixed currency test

* fixed tests in projectViewHolder, added sample project with different user currency

* fixed comment with the right information
* added error icon and methods in viewmodel to show the icon when the conditions are met

* renamed methods and documented output

* added test for creator and backer when email is unverified or undeliverable

* added test for when the icon is gone and removed unverified logic for backers

* added boolean fields for testing

* added test for when backer is verified or unverified

* removed non null call that may crash the app
* added extension to logging events

* added logging events for settings v2

* fixed lambda block in change password

* upgraded fabric

* added tracking events to koala and fabric

* added koala values to test classes

* removed unused method

* removed line and used raw strings in tests instead of constants
@Rcureton Rcureton requested a review from eoji November 27, 2018 17:44
Copy link
Contributor

@eoji eoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran it on my device 🚀

@Rcureton Rcureton merged commit 4100316 into settings-v3 Nov 27, 2018
@Rcureton Rcureton deleted the rc/update-v3 branch November 27, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants