-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Update #387
Merged
Merged
V3 Update #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le (#372) * added emailVerified field * added fields to check if the email is verified * added custom type mapping and mutation for userSendEmailVerification * added send email verification mutuation and tests * properly showing the send/re-send verification * removed id field from graph since we're not using it * made changes to viewmodel and tests * fixed view model tests * added verficationError test, added verificationButton output * renamed output * renamed output again
* showing manual network error check * added documentation for connection manager * fixed checkstyle errors we're g2g * fixed registering and unregistering our service * removed unregister from onDestroy * reverted line changes
* added register receiver to onPause * removed register from onStart
* fixed display bug with currency * fixed pledge amount text * fixed spacing for symbols * fixed formatting * fixed reward viewmodel test * fixed spacing and tests * added method for rewardviewodel to kscurrency * fixed reward pledge formatting * refactored projectCurrencyOptions method and added test for non US currency * fixed checkstyle error * fixed currency test * fixed tests in projectViewHolder, added sample project with different user currency * fixed comment with the right information
* added error icon and methods in viewmodel to show the icon when the conditions are met * renamed methods and documented output * added test for creator and backer when email is unverified or undeliverable * added test for when the icon is gone and removed unverified logic for backers * added boolean fields for testing * added test for when backer is verified or unverified * removed non null call that may crash the app
* added extension to logging events * added logging events for settings v2 * fixed lambda block in change password * upgraded fabric * added tracking events to koala and fabric * added koala values to test classes * removed unused method * removed line and used raw strings in tests instead of constants
eoji
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran it on my device 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What