Ensure that only supported locales are downloaded from the config #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
approved these changes
Jan 22, 2019
Rcureton
pushed a commit
that referenced
this pull request
Jan 24, 2019
* Updated strings and showing password warning (#369) * Updating the schema 2k18 (#370) * [Enhancement] - Send Verification email mutation and isEmailDeliverable (#372) * added emailVerified field * added fields to check if the email is verified * added custom type mapping and mutation for userSendEmailVerification * added send email verification mutuation and tests * properly showing the send/re-send verification * removed id field from graph since we're not using it * made changes to viewmodel and tests * fixed view model tests * added verficationError test, added verificationButton output * renamed output * renamed output again * [Enhancement] - Users see network error dialog (#374) * showing manual network error check * added documentation for connection manager * fixed checkstyle errors we're g2g * fixed registering and unregistering our service * removed unregister from onDestroy * reverted line changes * added register receiver to onResume (#376) * added register receiver to onPause * removed register from onStart * fixed bug in discovery layout by wrapping the toolbar and tabs in a linear layout (#379) * [QA FIX] - Fixed currency formatting case (#378) * fixed display bug with currency * fixed pledge amount text * fixed spacing for symbols * fixed formatting * fixed reward viewmodel test * fixed spacing and tests * added method for rewardviewodel to kscurrency * fixed reward pledge formatting * refactored projectCurrencyOptions method and added test for non US currency * fixed checkstyle error * fixed currency test * fixed tests in projectViewHolder, added sample project with different user currency * fixed comment with the right information * updating rubyzip gem for security (#382) * [Enhancement] - Change email error on Account page (#380) * added error icon and methods in viewmodel to show the icon when the conditions are met * renamed methods and documented output * added test for creator and backer when email is unverified or undeliverable * added test for when the icon is gone and removed unverified logic for backers * added boolean fields for testing * added test for when backer is verified or unverified * removed non null call that may crash the app * updating offline copy (#381) * [Enhancement] - Settings 2 Rollout Event Tracking (#383) * added extension to logging events * added logging events for settings v2 * fixed lambda block in change password * upgraded fabric * added tracking events to koala and fabric * added koala values to test classes * removed unused method * removed line and used raw strings in tests instead of constants * fixed icon error showing in account (#385) * [📼] ExoPlayer 2.7.0 -> 2.9.1 (#388) * bumping exoplayer after a futile subtitles attempt * fixing unsightly status bar on 21 and above * bumping support libraries because they clashed with dependencies' dependencies * Adding commit hook to ignore readme changes. (#390) * Adding commit hook to ignore readme changes. * Updating README (#391) * Adding wordmark to readme. Ignoring in CI. * [skip ci] nl * Updating the license in the README 🙃 * Updating Apollo from 0.5.0 to 1.0.0-alpha3. (#394) * [👩🏾💻👨🏿💻] Hiding change password and change email (#396) * added logic to hide the change password row for facebook users * Hiding both change password and change email rows. Did some refactoring for readability. Updated tests. * initially hiding error icon * Sending Settings v2 events to Koala (#389) * added event attributes and sending default properties with each event to koala * remvoed methods and only track fabric custom attr for currency * removed unused import * fixed checkstyle error * added content for firebase method * added tracking for firebase and fabric * fixed indentation * placed temp string for firebase * removed firebase tracking * removed unused imports * removed unused imports in extension file * removed fabric events * Change Email Fix (#395) * removed not null from change email and added logic for showing icon in account * Fixing button height and text color of warning copy. * making change email row include the icon * bumped up version name in both files and updated strings (#397) * [Enhancement] - Add Music Newsletter to our Settings (#399) * added the music newsletter in the xml, viewmodel, and tests * fixed subscribeAll test * [🚮] MixPanel removal (#398) * First pass of removing Mixpanel from the codebase: Removed import and metadata from build.gradle and manifest. Created a KoalaService retrofit instance to hit our tracking endpoint. Instead of using MixpanelAPI in KoalaTrackingClient, using KoalaService. Posting the tracking info as a Base64 encoded string like iOS. Adding obfuscated tracking properties that were set by Mixpanel * Created KoalaBackgroundService that uses android JobDispatcher to send tracking events in the background. Comes with free automatic retries woohoo. Also, it doesn't run the jobs unless there's a network connection. Fixed a crash in project cards if the project name is null. You can now add some bundled data to the JobDispatcher (with a max of 500K) * moved default properties to TrackingClientType interface * tests * Making constant time in MockKoala client and attempting to make tests pass * switching from a TestSubscriber to a BehaviorSubject so I can get the last value * Added tests for tracking default properties and project views. Project view tracking is broken because we always null for the user... * YAY TESTS ARE PASSING. Fixed bug where we never sent info about logged in user. Added missing fields to updates tracking. Removed prefixes from disco tracking. Alphabetizing. * Cleanup and logging out properties of successfully tracked event. * Checkstyle and properly logging properties. * removing koala endpoint placeholder * removing koala endpoints from makefile * Downgrade apollo 1.0.0-alpha3 -> 0.5.0 (#403) * downgrading apollo because we're not ready to go to 28 yet * fixed the margins on the spinner (#402) * added margin to the rate us row in settings (#405) * Settings a11y (#406) * Start of a11y changes. Button sizes. Privacy rows and started newsletter. * Accessibility party: Fixed large text cut off: Privacy rows Newsletters rows Voice over: Added accessibility label for the undeliverable warning icon Added copy for version UX: Manage project notifications - removed divider, allowed multiline text and fixed bug with delayed switches. * Reverting switch style * Filtering null currencies because it causes a crash. (#407) * added bintray url for exoplayer failure in circle (#410) * Attempt to fix crashes with uris (#409) * Create PULL_REQUEST_TEMPLATE.md (#412) * Fixing button height in 2FA screen. (#416) * Creator dashboard refactor (#413) * refactored creator dashboard to remove crashy fragment * updated tests and cleanup * [WIP] Heap integration for internal debug builds (#414) * Adding Heap to internal debug builds. Adding fake Heap ID for OSS. * Clean up and ignoring Heap for external builds lint. * Showing categories on thanks page (#417) * updated multidex version (#419) * updated constraintLayout gradle version (#423) * updated play services, firebase core and messaging (#422) * updated stripe library (#421) * updated rxBinding version (#420) * Updated Fastlane version (#424) Updated Gemlock file with latest Fastlane * Updated Missing Gems required by Fastlane (#425) - Updated gems needed by fastlane. - Added missing google cloud storage gem needed by fastlane. * Update Gemlock file (#426) * [skip ci] 2019 (#428) * Target API 28 2️⃣ 7️⃣ ➡️ 2️⃣ 8️⃣ (#427) * Targeting API 28 * updated heap * Updated Kotlin version, google services, and RxAndroid libraries `isConnectedOrConnecting` is deprecated * [UI] Snackbar style update (#429) * Removing rounded corners and margin from Snackbars because they were all forced to the bottom in API 28. * [Enhancement] - Settings and child activities transitions (#415) * added slide from top transition to Activitity extension class * added the exit transition for sliding down from the top * fixed duration being off * removed v21 anim * added alpha to exit animation * updated with changes from master * [Strings Update] - Updated Master with strings from our main repo (#430) * updated with strings from our main repo * removed chinese from strings * reverted italian back to master version * updated internal and external version name (#431) * removed heap from the application (#434) * [Bug Fix] - Android 8 + Samsung orientation theme fix (#435) * added screen rotation lock for oreo * added new theme for the settings activities * removed line * bumped version for bug fix (#436) * Updating android docker image to 28 (#438) * Sending koala timestamp in seconds vs millis.(#439) Updated tests. Changed Roboloectric MultiDex shadows to support AndroidX * Bumping internal/external versions to 1.10.3 in prep for release (#440) * nl and bumping version number * bumping internal * updating the strings * Fastlane updates. * [UI/Infrastructure] First pass of material theming (#433) * First pass of material theming -Updated buttons. -Fixed CollapsingToolbarLayouts. -Updated dialog styles. -Cleaned up unused files. -Fixed spacing in Messages layout. -Removed border from friend backing activity. -Updated toolbar styles. * lint * Ensure that only supported locales are downloaded from the config (#432) * merge fixes
eoji
added a commit
that referenced
this pull request
Jan 24, 2019
* Ensure that only supported locales are downloaded from the config (#432) * merge fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
Like the title - we only want to download localizations for the locales that we currently support in the app.
Story 📖
When new languages are supported on the web these locales are automatically returned in the config. We don't yet want to have these strings downloaded locally until we know we're supporting them in the app so this just allows us to filter based on what we know we support.
Thanks @pcreux for the Ruby tips.
See 👀
https://trello.com/c/WqK6zXfF/655-filter-for-supported-languages