Horizontal Rewards Design Sweep #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoji
reviewed
Apr 16, 2019
app/src/main/java/com/kickstarter/libs/utils/RewardItemDecorator.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/libs/utils/RewardItemDecorator.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/activities/BackingActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/viewholders/HorizontalRewardViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/viewholders/HorizontalRewardViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModelTest.kt
Outdated
Show resolved
Hide resolved
…rd scrolling on long rewards
eoji
reviewed
Apr 17, 2019
app/src/main/java/com/kickstarter/ui/activities/BackingActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/viewholders/HorizontalRewardViewHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModelTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/HorizontalRewardViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
RewardItemsback into the rewards so you can now see them.RewardItemDecoratorclass for the divider line between reward items. Previously we were inserting views in therewards_item_view.xml.How to QA? 🤔
Rewardsyou will see them as expected compared to the final designs.Story 📖
Horizontal Rewards Design Sweep
See 👀