Messages in drawer #526
Merged
Messages in drawer #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking awesome! (And I could see I have 3 unread messages 😅 ) I noticed, though, that when I go to
|
|
Yeah, I wasn't sure because we only get |
…ing test for mailbox title.
|
Sent mailbox doesn't show unread count |
Scollaco
reviewed
May 24, 2019
| import com.squareup.picasso.Picasso | ||
| import kotlinx.android.synthetic.main.discovery_drawer_logged_in_view.view.* | ||
|
|
||
| class LoggedInViewHolder(@NonNull view: View, @NonNull private val delegate: Delegate) : KSViewHolder(view) { |
There was a problem hiding this comment.
Shouldn't this class be final?
app/src/main/java/com/kickstarter/viewmodels/DiscoveryViewModel.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/LoggedInViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/LoggedInViewHolderViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/viewmodels/MessageThreadsViewModel.java
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/com/kickstarter/viewmodels/DiscoveryViewModel.java # app/src/test/java/com/kickstarter/viewmodels/DiscoveryViewModelTest.java
Scollaco
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❓
Messagesto the navigation drawer in Discovery.unreadMessagesCount> 0, we display the count to the right of the label.MessageThreadsActivity, we addedKoalaContext.Mailbox. Users can access their mailbox fromcreator_dashboard,drawer, or `profile.LoggedInViewHolderdidn't have a ViewModel so I added one so I could test!How to QA? 🤔
Messagesrow is only there for logged in users.Story 📖
Trello Story
See 👀