Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍔✨ Hamburger animation #527

Merged
merged 3 commits into from
May 24, 2019
Merged

🍔✨ Hamburger animation #527

merged 3 commits into from
May 24, 2019

Conversation

eoji
Copy link
Contributor

@eoji eoji commented May 24, 2019

What ❓

Showing an indicator on the menu icon when a user has unread messages.

How to QA? 🤔

  1. Verify the unadorned menu icon is shown when logged out.
  2. Verify the unadorned menu icon is shown when logged in and there are no unread messages.
  3. Verify the adorned menu icon is shown and animates when logged in and there are unread messages.

Story 📖

Trello Story

See 👀

@eoji eoji requested a review from Scollaco May 24, 2019 17:52
@eoji
Copy link
Contributor Author

eoji commented May 24, 2019

Hamburger Animaton when new activity/messages

Scollaco
Scollaco approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@eoji eoji merged commit 92cee7b into master May 24, 2019
@eoji eoji deleted the hamburger-animation branch May 24, 2019 23:12
@eoji eoji mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

Assignees
No one assigned
Labels
feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoji @Scollaco