Allow video url redirects #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Mar 15, 2017
| @@ -44,7 +43,7 @@ public void onCreate(final @Nullable Bundle savedInstanceState) { | |||
| setContentView(R.layout.video_player_layout); | |||
| ButterKnife.bind(this); | |||
|
|
|||
| viewModel.outputs.video() | |||
| viewModel.outputs.preparePlayerWithUrl() | |||
| this.startViewPledgeActivity = currentProject.compose(takeWhen(this.viewPledgeButtonClicked)); | ||
|
|
||
| this.shareButtonClicked | ||
| .compose(bindToLifecycle()) | ||
| .subscribe(__ -> this.koala.trackShowProjectShareSheet()); | ||
|
|
||
| this.playVideo | ||
| this.startVideoActivity |
|
|
||
| interface Outputs { | ||
| /** Emits the video for the player. */ | ||
| Observable<String> preparePlayerWithUrl(); |
There was a problem hiding this comment.
looooovin these new modern vm's
| @@ -51,7 +51,7 @@ public KSRendererBuilder(final @NonNull Context context, final @NonNull String v | |||
| @Override | |||
| public void buildRenderers(final @NonNull KSVideoPlayer player) { | |||
| final Allocator allocator = new DefaultAllocator(BUFFER_SEGMENT_SIZE); | |||
| final DataSource dataSource = new DefaultUriDataSource(context, videoLink); | |||
| final DataSource dataSource = new DefaultUriDataSource(context, null, videoLink, true); | |||
There was a problem hiding this comment.
so this is the flag that allows redirects?
def makes you miss swift's named arguments when reading this code......
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Video playback has been broken on our HQ environments with a 302 redirect error since our HQ video urls redirect.
Luckily the fix is nice: ExoPlayer has multiple constructors for
DefaultUriDataSource(which we use in ourKSRendererBuilder) one of which allows us to set a boolean forallowCrossProtocolRedirects. You go ExoPlayer.Bonus modernization of our #weird
VideoViewModeland refactoring of ourProjectViewModeland tests.