MBL-1211: Rewire current user email in AppEnvironment/AppDelegateViewModel #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1211/fix-current-user-email
branch
from
82b189b to
6ee9775
Compare
amy-at-kickstarter
changed the title
| @@ -107,6 +107,7 @@ public struct AppEnvironment: AppEnvironmentType { | |||
| apiService: AppEnvironment.current.apiService.logout(), | |||
| cache: type(of: AppEnvironment.current.cache).init(), | |||
| currentUser: nil, | |||
| currentUserEmail: nil, | |||
There was a problem hiding this comment.
Clear it on logout, too.
SwiftFormat found issues:
Generated by 🚫 Danger |
|
|
||
| XCTAssertEqual(AppEnvironment.current.currentUserEmail, "[email protected]") | ||
|
|
||
| AppEnvironment.logout() |
There was a problem hiding this comment.
This makes this not-really-a-unit-test but I'm OK with the weirdness.
scottkicks
approved these changes
Mar 5, 2024
amy-at-kickstarter
deleted the
feat/adyer/MBL-1211/fix-current-user-email
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fix
AppEnvironment.current.currentUserEmail, which did not appear to be correctly saving the currently logged-in user's e-mail.🤔 Why
We need the user's e-mail on the Thanks page for post-campaign backings. I noticed that we had this
currentUserEmailproperty onEnvironment, but it wasn't working correctly. I did some digging and I figured it's because the signal is being deallocated before the value is set.An interesting question is why
currentUserEmailisn't just part ofcurrentUser. Apparently the V1Userobject doesn't appear to have an e-mail attached to it, and the e-mail is coming from GraphQL, instead. It's a bit messy but I wanted to keep this change fairly low-profile instead of doing more refactoring.