[MBL-1298] Use correct project country for currency symbol #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
approved these changes
Mar 27, 2024
| PostCampaignRewardsSummaryViewData( | ||
| rewards: rewards, | ||
| selectedQuantities: selectedQuantities, | ||
| projectCountry: projectCurrencyCountry, | ||
| projectCountry: project.country, |
There was a problem hiding this comment.
Huh, interesting. What's the difference between project.country and project.stats.currentCountry?
There was a problem hiding this comment.
currentCountry is based on the user's location! It's what we use to determine what to convert currency to, for example. It's the opposite of what we want for the actual project's country
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Use
project.countryinstead ofproject.stats.currentCountryto determine currency labels, since the latter refers to the user's location, not the projects. It also simplifiesPostCampaignCheckoutDatato avoid sendingprojectfields as extra params.👀 See
Jira
✅ Acceptance criteria