[MBL-1391] Payment Intent StripeIntentContextType and CheckoutID #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
force-pushed
the
scott/mbl-1391/late-pledge-payment-intent-context
branch
from
163fe42 to
b6017d4
Compare
scottkicks
requested review from
a team and
amy-at-kickstarter
and removed request for
a team
| ) { | ||
| self.projectId = projectId | ||
| self.amountDollars = amountDollars | ||
| self.digitalMarketingAttributed = digitalMarketingAttributed | ||
| self.paymentIntentContext = paymentIntentContext | ||
| } | ||
| } |
There was a problem hiding this comment.
Out of scope for this PR, but this type seems redundant to GraphAPI.CreatePaymentIntentInput
…ttps://github.com/kickstarter/ios-oss into scott/mbl-1391/late-pledge-payment-intent-context
scottkicks
changed the title
Generated by 🚫 Danger |
scottkicks
force-pushed
the
scott/mbl-1391/late-pledge-payment-intent-context
branch
from
90830ff to
8362cfa
Compare
| @@ -334,6 +337,7 @@ public final class PledgePaymentMethodsViewModel: PledgePaymentMethodsViewModelT | |||
| ) | |||
| clientSecretSignal = stripeIntentService.createPaymentIntent( | |||
| for: project.graphID, | |||
| checkoutId: checkoutId, | |||
There was a problem hiding this comment.
Is this one already graph-encoded?
amy-at-kickstarter
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates the call to CreatePaymentIntent to include the StripeIntentContextType and the Checkout ID.
🤔 Why
We need this information to store additional metadata in the payment intent when it's created for on-session payments. This is helpful when the backend tries to debug any issues during checkout.
🛠 How
Checkout ID
CreateCheckoutMutationto .createPaymentIntent call sitesContext
paymentIntentContext(defined in GraphAPI model) toCreatePaymentIntentInput.createPaymentIntentcall sites👀 See
No UI changes
♿️ Accessibility
No accessibility changes needed
🏎 Performance
Same
✅ Acceptance criteria
⏰ Next Steps