Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1444] Remove Consent Management Dialog Feature Flag #2071

Merged
merged 1 commit into from
May 29, 2024

Conversation

scottkicks
Copy link
Contributor

📲 What

Removes the Consent Management Dialog Feature Flag.

🤔 Why

It has been on at 100% for some time now. It's time to say goodbye.

🛠 How

  • Remove flag from RemoteConfigFeature and all subsequent tests and helpers
  • Remove any guards that use this feature flag.
  • Verify that the feature is working as expected.

👀 See

Screenshot 2024-05-29 at 2 08 53 PM

♿️ Accessibility

No changes

🏎 Performance

Same

✅ Acceptance criteria

  • Dialog still shows as expected.

⏰ TODO

  • Update the flag in the remote config dashboard to stop sending it to new builds.

@scottkicks scottkicks self-assigned this May 29, 2024
@scottkicks scottkicks marked this pull request as ready for review May 29, 2024 17:36
@scottkicks scottkicks requested review from a team and amy-at-kickstarter and removed request for a team May 29, 2024 17:36
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
}

func testRequestATTrackingAuthorizationStatus_WhenAppBecomesActive_WhenAdvertisingIdentifierNil_WhenConsentManagementFeatureFlagOff_WhenShouldRequestAuthorizationStatusTrue_RequestAllowed_DoesNotShowConsentDialogAndDoesNotUpdateAdId(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the test name here.

@scottkicks scottkicks merged commit 68afecd into main May 29, 2024
4 checks passed
@scottkicks scottkicks deleted the scott/debt/consent-management-flag-cleanup branch May 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants