[MBL-1554] Fix survey push notifications for new surveys #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
force-pushed
the
surveyPushNotifications
branch
from
a4c1fbb to
5324b82
Compare
ifosli
requested review from
a team and
scottkicks
and removed request for
a team
ifosli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Allow new surveys to be opened from push notifications by using the url path provided instead of relying on the survey response id.
🤔 Why
New surveys don't have a unique id.
👀 See
Jira
No screen recording of this because push notifications are a pain to work with, but I've verified that it works for new surveys and that push notification for old surveys have the exact same data format.
✅ Acceptance criteria