[MBL-1445] Remove Facebook Interstitial Feature #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
scottkicks
added a commit
that referenced
this pull request
Jul 23, 2024
* remove facebook interstitial feature view controller and view model * remove feature flag * update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Remove this feature. It was never rolled out, and it likely won't be.
Heres the original tech doc from 2022 for context around what this feature was supposed to address.
The short version is that we were planning to deprecate our FB login altogether because they have a habit of updating their API without telling us, potentially causing a broken UX. This, however, was never prioritized and eventually de-prioritized completely.
🛠 How
SetPasswordViewControllerandSetPasswordViewModel👀 See
No visual changes
✅ Acceptance criteria