Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1609] Handle no add-ons/no reward cases in the add-ons VC #2135

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Aug 28, 2024

📲 What

Handle the no rewards and no add-ons case for bonus support in the add-ons view controller.

Note: This also handles wiring up the bonus support to the pledge vc (in a super quick way and tags the tech debt ticket to actually remote the bonus support class/references from the pledge vc entirely).

👀 See

Jira

No reward case No add-ons case
image image

♿️ Accessibility

Untested since it's not adding any new UI components

✅ Acceptance criteria

  • Add-ons VC is always presented in the newly organized flow
  • Bonus support/pledge amount is settable and validated (continue button is disabled if it's too high)
  • Pledge VC presents correct bonus support/pledge amount value to user

⏰ TODO

  • New string should use translatable version instead of being hard-coded. I'll update that before submitting if the string translations are ready.

@ifosli ifosli self-assigned this Aug 28, 2024
@ifosli ifosli requested a review from scottkicks August 28, 2024 16:13
@ifosli ifosli marked this pull request as ready for review August 28, 2024 16:15
@ifosli ifosli merged commit eaacccb into main Aug 28, 2024
5 checks passed
@ifosli ifosli deleted the noAddonsBonus branch August 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants