[MBL-1714] "Estimated Shipping" Showing When There's No Estimated Shipping #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput can complete * also updates helper functions so that they return String? instead of String
ifosli
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
see jira ticket
🤔 Why
Estimated shipping views should only show when appropriate. Otherwise, it should be entirely hidden.
🛠 How
The output in charge of hiding the estimated shipping stackview wasn't completing because there isn't a selected shipping rule when opening the manage pledge flow
I've also updated the estimated shipping text helpers to return
String?instead ofStringto make that clearer.👀 See
✅ Acceptance criteria