Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-2063] Delete PostCampaignCheckout Code #2273

Merged
merged 5 commits into from
Feb 10, 2025
Merged

[MBL-2063] Delete PostCampaignCheckout Code #2273

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23df113
remove ViewController and ViewControllerTests
scottkicks Feb 4, 2025
bc50df3
remove ViewModel and ViewModelTests
scottkicks Feb 4, 2025
cb79af4
Merge branch 'main' into scott/delete-legacy-post-campaign-view
scottkicks Feb 5, 2025
72cce0e
Merge branch 'main' into scott/delete-legacy-post-campaign-view
scottkicks Feb 10, 2025
2642f97
[MBL-2063] Delete Legacy RewardsCollectionView (#2274)
scottkicks Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Kickstarter-iOS/Features/ConfirmDetails/Controllers/ConfirmDetailsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,14 @@ final class ConfirmDetailsViewController: UIViewController, MessageBannerViewCon
self.present(navigationController, animated: true)
}

private func goToCheckout(data: PostCampaignCheckoutData) {
let vc = PostCampaignCheckoutViewController.instantiate()
vc.configure(with: data)
vc.title = self.title

self.navigationController?.pushViewController(vc, animated: true)
private func goToCheckout(data _: PostCampaignCheckoutData) {
// TODO: ConfirmDetails Will be removed as a part of our legacy checkout code refactor/cleanup. Commenting this out for now.

// let vc = PostCampaignCheckoutViewController.instantiate()
// vc.configure(with: data)
// vc.title = self.title
//
// self.navigationController?.pushViewController(vc, animated: true)
}
}

Expand Down
1 change: 0 additions & 1 deletion ...ter-iOS/Features/PledgePaymentMethods/Controller/PledgePaymentMethodsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ final class PledgePaymentMethodsViewController: UIViewController {

assert(
topViewController is NoShippingPledgeViewController ||
topViewController is PostCampaignCheckoutViewController ||
topViewController is NoShippingPostCampaignCheckoutViewController,
"PledgePaymentMethodsViewController is only intended to be presented as part of a pledge flow."
)
Expand Down
5 changes: 5 additions & 0 deletions ...er-iOS/Features/PledgeView/Controllers/NoShippingPostCampaignCheckoutViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,11 @@ extension NoShippingPostCampaignCheckoutViewController: PledgeViewControllerMess

// MARK: - STPApplePayContextDelegate

enum PostCampaignCheckoutApplePayError: Error {
case missingPaymentMethodInfo(String)
case missingPaymentIntent(String)
}

extension NoShippingPostCampaignCheckoutViewController: STPApplePayContextDelegate {
func applePayContext(
_: StripeApplePay.STPApplePayContext,
Expand Down
Loading