[MBL-2021] Disable "authenticate card" after completion of 3DS auth in PPO #2282
+16
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
approved these changes
Feb 12, 2025
ifosli
approved these changes
Feb 13, 2025
| @@ -35,6 +35,7 @@ typealias PPOProjectCardViewModelType = Equatable & Hashable & Identifiable & Ob | |||
| final class PPOProjectCardViewModel: PPOProjectCardViewModelType { | |||
| @Published private(set) var card: PPOProjectCardModel | |||
| @Published var isLoading: Bool = false | |||
| @Published var isComplete: Bool = false | |||
There was a problem hiding this comment.
Nit: Since these booleans are interconnected (at least, I'd assume the card can't be loading and complete at the same time), what do you think of doing an enum "state" here as well, instead of two separate bools? I'm okay with this as-is, though, if you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
After the "Authenticate Card" flow is complete, the button now disables.
🛠 How
PPOActionState was already being propagated into the PPOProjectCardViewModel, so I added a new "isComplete" flag to that, which is reacted to by the PPOProjectCard.