Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce credentials provider (#3224) #1

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

kimmking
Copy link
Owner

References:

  1. Request New Feature: allowing the ability to reset password during runtime for Jedis's auth redis/jedis#1602 and related PRs. Current PR is probably better than handling in JedisFactory
  2. CredentialsProvider class added to support password rotation redis/redis-py#2261 - main reason of this PR
  3. Password Rotation support - Add a CredentialProvider interface/class and set your own provider redis/lettuce#1774
  4. Security Flaw In How Jedis Stores Server Password redis/jedis#632

  • Introduce credentials provider

  • use volatile

  • Test in Sentineled mode

  • Support CharSequence in DefaultRedisCredentials

  • Added doc for prepare() and cleanUp()

  • Test the provider interface

  • Added example

  • Removed deprecations

References:

1. #1602 and related PRs. Current PR is probably better than handling in JedisFactory 
2. redis/redis-py#2261 - main reason of this PR 
3. redis/lettuce#1774 
4. #632 

---

* Introduce credentials provider

* use volatile

* Test in Sentineled mode

* Support CharSequence in DefaultRedisCredentials

* Added doc for prepare() and cleanUp()

* Test the provider interface

* Added example

* Removed deprecations
@kimmking kimmking merged commit 6b84532 into kimmking:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants