fix: stack overflow in fill
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filling a large area (such as the entire screen starting from one of the corner pixels) can result in very deeply nested recursion in `fill_rec`, manifesting as a crash when calling `fill(...)` from python. my approach to fixing this is to use a stack of coordinates to visit in a loop rather than recursing. this stack is initialised with a worst-case capacity of every pixel in the clipping region to avoid reallocs. i've added a test that does a worst-case fill on a large canvas to validate the solution.
|
resolves #615 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filling a large area (such as the entire screen starting from one of the corner pixels) can result in very deeply nested recursion in
fill_rec, manifesting as a crash when callingfill(...)from python.my approach to fixing this is to use a stack of coordinates to visit in a loop rather than recursing. this stack is initialised with a worst-case capacity of every pixel in the clipping region to avoid reallocs.
i've added a test that does a worst-case fill on a large canvas to validate the solution.
unrelated: while working on this i noticed that
test_sound_setwas failing. thesoundinstance in the test was missing the last two volumes & effects that were being asserted, so i added them to the.set(...)call. that change is in a separate commit from thefill_recfix.let me know what you think. thanks!