Refactored the ZimFileRendering test to align with the new ZIM file, as the content of the mainPage in wikipedia_fr_climate_change_mini has changed.
#4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, as the content of the `mainPage` in `wikipedia_fr_climate_change_mini` has changed.
MohitMaliFtechiz
force-pushed
the
refactored_zim_file_rendering_test
branch
from
5f75196 to
5dfb9ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4261 +/- ##
============================================
+ Coverage 57.74% 58.93% +1.18%
- Complexity 1604 1651 +47
============================================
Files 316 325 +9
Lines 14075 14296 +221
Branches 1745 1756 +11
============================================
+ Hits 8128 8425 +297
+ Misses 4756 4641 -115
- Partials 1191 1230 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
ZimFileRenderingtest to align with the new ZIM file, as the content of themainPageinwikipedia_fr_climate_change_minihas changed.See #4259 (comment), and #4259 (comment).