Use lookup tables instead of linear search with memchr
#625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several places use
memchr
with a byteset. This commit refactors thesecode paths to construct a lookup table from
u8
->bool
, where anindex is set to
true
if the byte is present in the given slice.This change removes linear scans that occur in loops, which changes
these functions runtime complexity from
O(m * n)
toO(m + n)
.